Remove door codes for expired memberships - #2184
Merged
Merged
Conversation
c1ndytat
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When SCE memberships expire, those members are no longer entitled to a door code. Furthermore, door codes are reset by the department every academic year. Clark never addressed these issues, and memberships that expired were still tied to a door code months, and even years, after expiry.
The Fix
Every time a user logs into Clark, there is a check to see when their membership expires. If it's already expired, the door code is removed from their profile and their status is set back to
NON_MEMBER. This is the correctly expected behavior of an expired membership, and fixes any potential scenarios where previous members have access to door codes that may or may not work on the room door.