Skip to content

[codex] Fix single-arch Darwin universal binary packaging - #2

Merged
Saafo merged 1 commit into
mainfrom
codex/saafo/fix-single-arch-lipo
Jun 25, 2026
Merged

Saafo merged 1 commit into
mainfrom
codex/saafo/fix-single-arch-lipo

Conversation

@Saafo

@Saafo Saafo commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Reason

  • When the iOS build config contains only one architecture, lipo -create was still invoked and produced an output that looked like a fat binary while containing a single architecture.
  • Bazel Rust builds could not link against this ios-arm64/libogg.a artifact because the linker did not recognize it correctly.

Changes

  • Check archs.len() in create_universal_binary.
  • Copy the architecture-specific artifact directly into universal/lib when there is only one architecture.
  • Only invoke lipo when there are two or more architectures.
  • Verified with cargo fmt --check.

@Saafo
Saafo marked this pull request as ready for review June 25, 2026 11:29
@Saafo
Saafo merged commit 6de3c49 into main Jun 25, 2026
7 checks passed
@Saafo
Saafo deleted the codex/saafo/fix-single-arch-lipo branch June 25, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant