⚙️[Chore] Reinstate Secure Tools commit convention - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
Secure Tools now has one documented and testable commit convention:
<Gitmoji>[<Action>] <imperative subject>. The repository-owned validator accepts only the 14 fixed Gitmoji/action pairs, reports offending commit SHAs and subjects, and rejects mismatched pairs, spacing errors, empty subjects, unknown actions, and repeated Conventional Commit syntax.The existing
Validate static toolsworkflow checks only non-merge commits in the pull request’s actual base-to-head range and checks the pull request title with the same structural rule. Technical merge commits are excluded by topology, so the established normal merge-commit workflow remains supported. Published history is unchanged.Changes
Verification
npm run test:commit-messagesnode scripts/validate-commit-message.mjs --range origin/v2.1 HEADnpm testnpm run buildnode tests/ocr-smoke.test.mjsgit diff --checkTracks #81.
This PR targets
v2.1and remains unmerged for explicit review. It does not rewrite history, change product behavior, promote tomain, or create a release/tag.