test: pin generated-directory exclusion in inventory discovery - #14
Closed
v01dst wants to merge 1 commit into
Closed
test: pin generated-directory exclusion in inventory discovery#14v01dst wants to merge 1 commit into
v01dst wants to merge 1 commit into
Conversation
Issue SinghCod3r#3 asks that generated directories (.git, node_modules, .venv, caches, build, dist) be excluded from repository analysis and that the behavior be covered by regression tests. The os.walk pruning in discover_files already applies settings.exclude_patterns to dirnames, but nothing pinned it. Two tests: a fixture tree with generated directories alongside real sources asserts no discovered path touches any generated directory, and that legitimate sources remain discoverable.
Author
|
Closing this. I was batch-generating PRs across repos while focused on my own project — that wasn't fair on reviewers' time, and I've stopped. Apologies for the noise. |
Owner
|
@v01dst , would you like to work on this repo. ? If yes then do let me know, as i need someone to make the architecture more better. So please tag me on any issue if you find that can be done. Also you can raise pr whether you think that area needs to be fixed. You just don't have to see the issues tab too. But tag me too so that I could get notified as well. |
Author
|
@SinghCod3r i will work on it as soon as possible , thanks for inviting me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository analysis should never traverse generated directories (.git, node_modules, .venv, caches, build, dist), and the behavior needed regression coverage per #3.
The
os.walkpruning indiscover_filesalready appliessettings.exclude_patternstodirnamesbefore descending. This PR pins that contract with tests, per the acceptance criteria:src/,lib/)Verified:
pytest tests/unit/test_inventory.py— 2 passed.Closes #3