fix(mac): regenerate app icons for consistent sizing across all surfaces - #873
Merged
Merged
Conversation
Follow-up to the icon update in Snapmaker#858/Snapmaker#867. Three assets still carried inconsistent geometry after that change: - Icon.icns / Snapmaker_Orca.icns: the 16/32px frames were full-bleed while 64px+ frames carried a 0.89 tile ratio, and the @2x retina variants (ic11-ic14) present in the previous file were dropped, so the icon visibly changed size between Dock, Cmd-Tab and Finder contexts. The 1024px source frame was also off-center (81px top vs 33px bottom margin). Regenerated via iconutil from the 1024px master normalized to the Apple icon grid (824/1024 tile, centered), giving a uniform 0.805 ratio across all sizes with @2x variants restored. - Snapmaker_Orca-mac_256px.ico (macOS Dock taskbar icon, MainFrame): re-exported from the same normalized 256px frame so the custom Dock icon matches the bundle icon sizing. - splash_app_icon.svg: the splash glyph was an early thinner version of the new mark; retraced the glyph from the 1024px icon master (same black tile, tile color #171717 unchanged).
zackaree-shen
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to the Orca icon update in #858/#867. After auditing every icon surface shipped by those PRs, three assets still carried inconsistent geometry:
1.
Icon.icns/resources/images/Snapmaker_Orca.icns(app bundle icon)The icns regenerated in #858 had three defects, verified by parsing every chunk:
ic12/ic13retina variants; the Feature/update orca icon #858 file dropped all ofic11–ic14.Fixed by extracting the 1024px master, normalizing it to the Apple icon grid (824/1024 tile, centered — matching the 0.805 ratio the pre-#858 icns already used), and regenerating via
iconutilfrom a uniformly-composed iconset. All sizes now share the same 0.805 layout andic11–ic14are restored.2.
Snapmaker_Orca-mac_256px.ico(macOS Dock taskbar icon,MainFrame.cpp)#858's "regenerate full-bleed to fix smaller taskbar icon" commit only regenerated the Windows
Snapmaker_Orca.ico(all 6 sizes full-bleed ✓) — the-mac_256px.icoused bywxTBI_DOCKon macOS was missed and kept its baked-in padding, so the custom Dock icon rendered smaller than the bundle icon. Re-exported from the same normalized 256px frame so both surfaces match.3.
splash_app_icon.svg(splash screen logo,GUI_App.cpp)The splash still used an early, noticeably thinner version of the new glyph (last touched 2026-06-18, before the icon redesign). No vector source of the final glyph exists in the repo, so the glyph was retraced from the 1024px icon master (directed-edge contour tracing + Ramer–Douglas–Peucker simplification, 1560 → 514 points). Tile structure unchanged (
#171717, rx=20, 140 viewBox); only the glyph path was replaced. Purerect+M/L/Zpath, fully compatible with nanosvg.Screenshots/Recordings/Graphs
Verification of the regenerated icns (every chunk parsed and measured):
iconutil -c iconsetround-trip parses cleanly; both icns copies are byte-identical (md5).Tests
./build_release_macos.sh -sxbuilds cleanly (arm64, Ninja Multi-Config, exit 0).appbundle with correct md5, andCFBundleIconFile→Icon.icnsresolvesNSImagerenders the new icns at 16/32/64/128px pixel-identical to the source iconset (avg diff 0.0) — confirms all chunk types (incl. iconutil's raw-ARGBic04/ic05) decode correctlySnapmaker_Orca_macos_arm64_c76c3d5.dmg(170MB), mounted and verified bundle contents + adhoc signatureCFBundleTypeIconFile=images/Snapmaker_Orca.icnsfor.3mf) resolve to the clean icon viaNSWorkspace.icon(forFile:)Note for reviewers/testers: if a Mac that had many dev builds or DMG-launched copies of the app shows a noisy
.3mfdocument icon, that is stale/dangling LaunchServices registration on that machine (not this asset) — re-registering the installed app and clearing~/Library/Caches/com.apple.iconservices*fixes it.