fix(buy-crypto): title the amount screen "Buy USDC" and polish fundin… - #2481
Merged
Conversation
…g buttons - Amount screen header now reads "Buy USDC" rather than "Buy crypto". It is titled independently in two places — getBuyCryptoTitle for the embedded card-funding flow and useDepositOption for the global deposit modal — so both are updated, along with the test that asserts they stay aligned. - Drop the USD-equivalent line under the amount input. The field is already denominated in USDC, so "$3" under "3" only restated it; its Intl.NumberFormat computation goes with it. - Set the enabled "Continue to payment" label to text-black at the call site. The brand variant already forces black, but the label had previously come out white in some renders (see the note in button.tsx). - Read the local-currency chips on "Fund your wallet" from the static CARD_FUND_LOCAL_PAYMENT_METHODS map via getCardFundLocalPaymentMethods, matching what CardFundOptions already did. This drops three-to-four TransFi payment-config requests on open and renders the rails on first paint instead of once the responses land. - Round both payment hand-off buttons to a pill and make the secondary label white. button.tsx appends rounded-[30px] to brand buttons after the caller's className, so the green button was already a pill and the grey one was not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g buttons