Skip to content

fix(buy-crypto): title the amount screen "Buy USDC" and polish fundin… - #2481

Merged
MayankMittal1 merged 1 commit into
masterfrom
claude/payment-button-color-dcdc58
Sep 7, 2026
Merged

fix(buy-crypto): title the amount screen "Buy USDC" and polish fundin…#2481
MayankMittal1 merged 1 commit into
masterfrom
claude/payment-button-color-dcdc58

Conversation

@mul53

@mul53 mul53 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

…g buttons

  • Amount screen header now reads "Buy USDC" rather than "Buy crypto". It is titled independently in two places — getBuyCryptoTitle for the embedded card-funding flow and useDepositOption for the global deposit modal — so both are updated, along with the test that asserts they stay aligned.
  • Drop the USD-equivalent line under the amount input. The field is already denominated in USDC, so "$3" under "3" only restated it; its Intl.NumberFormat computation goes with it.
  • Set the enabled "Continue to payment" label to text-black at the call site. The brand variant already forces black, but the label had previously come out white in some renders (see the note in button.tsx).
  • Read the local-currency chips on "Fund your wallet" from the static CARD_FUND_LOCAL_PAYMENT_METHODS map via getCardFundLocalPaymentMethods, matching what CardFundOptions already did. This drops three-to-four TransFi payment-config requests on open and renders the rails on first paint instead of once the responses land.
  • Round both payment hand-off buttons to a pill and make the secondary label white. button.tsx appends rounded-[30px] to brand buttons after the caller's className, so the green button was already a pill and the grey one was not.

…g buttons

- Amount screen header now reads "Buy USDC" rather than "Buy crypto". It is
  titled independently in two places — getBuyCryptoTitle for the embedded
  card-funding flow and useDepositOption for the global deposit modal — so
  both are updated, along with the test that asserts they stay aligned.
- Drop the USD-equivalent line under the amount input. The field is already
  denominated in USDC, so "$3" under "3" only restated it; its
  Intl.NumberFormat computation goes with it.
- Set the enabled "Continue to payment" label to text-black at the call site.
  The brand variant already forces black, but the label had previously come
  out white in some renders (see the note in button.tsx).
- Read the local-currency chips on "Fund your wallet" from the static
  CARD_FUND_LOCAL_PAYMENT_METHODS map via getCardFundLocalPaymentMethods,
  matching what CardFundOptions already did. This drops three-to-four TransFi
  payment-config requests on open and renders the rails on first paint
  instead of once the responses land.
- Round both payment hand-off buttons to a pill and make the secondary
  label white. button.tsx appends rounded-[30px] to brand buttons after the
  caller's className, so the green button was already a pill and the grey
  one was not.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
solid-app Ignored Ignored Sep 7, 2026 12:15pm UTC
solid-app-staging Ignored Ignored Sep 7, 2026 12:15pm UTC

Request Review

@claude

claude Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@MayankMittal1
MayankMittal1 merged commit 581f7f7 into master Sep 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants