code review for the notifications aggregator service. - #13
Open
argahsuknesib wants to merge 2 commits into
Open
Conversation
pheyvaer
requested changes
Mar 14, 2024
pheyvaer
left a comment
pheyvaer
left a comment
There was a problem hiding this comment.
- Can you update the title of the PR, because now it doesn't mention the functionality that you add?
- Why are there no tests for this?
argahsuknesib
changed the title
Collaborator
Author
|
Thanks for the comments. I will add the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @pheyvaer,
I recently developed this service on top of the solid pods for the clients to receive the notifications. I create this pull request for the code review / possible comments from you. Upon which, this branch will be merged to main. Thanks!