Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
Important Review skippedToo many files! This PR contains 412 files, which is 262 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Pro+ to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (412)
You can disable this status message by setting the Comment |
Description
This PR delivers the PostgreSQL traversal/runtime work as a complete, validated stack:
drivers/pg/v2package with the finalized connection-local runtime indrivers/pg.pg.NewPoolremains the caller-owned pool constructor and installs lifecycle hooks.*pgxpool.Pooltopg.NewDriverordawgs.Open.Benchmark deltas vs
mainCompared
main(9c2f496) with this branch (cd975e4) for the two shared benchmark datasets,baseandtraversal_shapes. Each side used two 50-iteration captures per scenario, one warm-up, and one worker. Negative deltas are faster.All 21 shared scenarios improved. These are cumulative branch-vs-
mainresults, not an isolation of only the final runtime-retirement commit.Type of Change
Testing
make test_allwithCONNECTION_STRINGset)Full suites were run successfully against both supplied PostgreSQL and Neo4j targets. Focused race tests for
./cmd/benchmarkand./drivers/pg, generated-test updates, linting, formatting, and diff checks also passed.Screenshots (if appropriate):
N/A
Driver Impact
drivers/pg)drivers/neo4j)Checklist
go.mod/go.sumare up to date if dependencies changed