feat(anchors): add TLS certificate pinning to AnchorVerifier (#780) - #820
Open
ZacLou wants to merge 1 commit into
Open
feat(anchors): add TLS certificate pinning to AnchorVerifier (#780)#820ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…-split#780) - Add pinnedCertFingerprints option to AnchorVerifierOptions - Add getCertFingerprint helper using Node.js tls module (dynamic import) - Check certificate before TOML fetch when fingerprint is configured - Add verifyCertificatePinning(domain) public method - Add CertificatePinningError with domain, expected, and actual fingerprints - Add unit tests for error shape and options passthrough Closes Stellar-split#780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional TLS certificate pinning to AnchorVerifier so compromised DNS or rogue CAs cannot silently redirect anchor requests to malicious servers.
Changes
Closes #780