feat: emit RatioUpdatedEvent in set_ratio + add unit tests (Closes #11, Closes #12) - #57
Open
ZacLou wants to merge 3 commits into
Open
feat: emit RatioUpdatedEvent in set_ratio + add unit tests (Closes #11, Closes #12)#57ZacLou wants to merge 3 commits into
ZacLou wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11, Closes #12
Changes
#12 - Emit RatioUpdatedEvent from set_ratio
RatioUpdatedEventstruct toevents.rswithprogram_idandreward_per_pointfieldsset_ratio()after updating the ratio in storage#11 - Add unit tests for set_ratio and withdraw_remaining
set_ratio_updates_reward_per_point: verifies successful ratio updateset_ratio_rejects_zero: verifies validation rejects 0set_ratio_rejects_negative: verifies validation rejects negative valuesset_ratio_rejects_non_maintainer: verifies auth checkwithdraw_remaining_fails_when_active: verifies program-paused guardwithdraw_remaining_rejects_non_maintainer: verifies auth checkTotal: 6 new tests covering both happy paths and error conditions.