feat: add tower rate limiting on public API routes (Closes #26) - #67
Open
ZacLou wants to merge 2 commits into
Open
feat: add tower rate limiting on public API routes (Closes #26)#67ZacLou wants to merge 2 commits into
ZacLou wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
Changes
Adds in-memory token bucket rate limiting to public API routes:
rate_limitmiddleware: Simple sliding-window rate limiter keyed byX-Forwarded-ForheaderRATE_LIMIT_REQUESTS(default 100) andRATE_LIMIT_WINDOW_SECS(default 60)429 Too Many Requestswithretry_after_secswhen limit exceededwaveflow_api_rate_limited_totalcounter on each rejectionRATE_LIMIT_REQUESTS=0to disable rate limitingFiles changed
crates/api/src/middleware.rs— Addedrate_limitmiddleware functioncrates/api/src/main.rs— Wired into public router (applied before request_id layer)Behavior
max_requestsperwindow_secswindow_secselapses since first request in window