Skip to content

Fix Season localization case to include number placeholder - #134

Open
arnnalddo wants to merge 1 commit into
SublerApp:mainfrom
arnnalddo:fix/season-localization
Open

Fix Season localization case to include number placeholder#134
arnnalddo wants to merge 1 commit into
SublerApp:mainfrom
arnnalddo:fix/season-localization

Conversation

@arnnalddo

Copy link
Copy Markdown
Contributor

The season case in MetadataResult.swift was mapping to "{Season}", missing the number placeholder #. This caused the UI to display incomplete localized strings for season numbers.

This updates the mapping to "{Season #}" for consistency with the MP42Foundation fix.

Depends on: SublerApp/MP42Foundation#3

See attached screenshots for the issue before the fix:

Captura de pantalla 2026-07-24 a la(s) 03 59 19 Captura de pantalla 2026-07-24 a la(s) 03 59 43

@galad87

galad87 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

But it's correctly translated in the Italian localisation, so while I guess it should include a #, I don't see how it affects the localisation. Plus changing that key will break existing settings.

@arnnalddo

Copy link
Copy Markdown
Contributor Author

I noticed this while working on the Brazilian Portuguese translation and updating Latin American Spanish on Transifex. I saw that several strings were missing, so I figured one of those removed translations might have caused the issue with missing localizations in the UI. On my end, updating the mapping fixed the preview.

I didn’t edit the localization files directly since you mentioned translations should only be done via Transifex, which is why I looked into modifying the code mapping instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants