Design update - #1
Open
Leannapelham wants to merge 10 commits into
Open
Conversation
[no ci]
[no ci]
The file is a machine-specific yarn artifact (it stores systemParams like darwin-arm64-141), so it produced a spurious diff on every machine. There is no package.json and yarn.lock is empty, so it recorded nothing. Also adds /node_modules/ to .gitignore, which had no entry for it.
base.html.twig loaded https://cdn.tailwindcss.com plus an inline v3-format tailwind.config, bypassing symfonycasts/tailwind-bundle entirely. The theme now lives in assets/styles/app.css as a v4 @theme block, and the custom component rules moved there too, inside @layer components so utilities can override them. {% block javascripts %} is back to holding only importmap('app'), matching the Symfony recipe. Also adds the missing viewport meta, lang="en", and a {% block title %} the child templates can override. Dropped three theme entries with no uses anywhere: accent.light, boxShadow.glow and fontFamily.body, along with the .item-card rules.
The six items were hardcoded six times over in index.html.twig and show.html.twig
rendered a single unrelated item. They now live in a private const ITEMS keyed
by id, standing in for the Item entity until Doctrine takes over. show() looks
one up and 404s on a miss instead of ignoring its {id}.
Template fixes: three cards linked to the wrong item; index.html.twig emitted a
nested <body> and a trailing </html>; a dead <script src="data.js"> populated an
empty #item-grid via an undefined LOST_ITEMS; show.html.twig had a literal
${item.colorClass}, no image at all, and two href="index.html" links. The card
grid is now a list with per-item aria-labels and an empty state.
Contributor
|
@kbond I added data fixtures to the project, but I got a bit confused about the difference between "factories" and "stories". I chose stories, but I'd like your opinion on which one fits better in this case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full design update for course project