[Feature] Updating CMake for Windows Builds - #154
Merged
Merged
Conversation
ddbaptiste
requested changes
Jun 22, 2026
ddbaptiste
reviewed
Jun 22, 2026
ddbaptiste
left a comment
ddbaptiste
left a comment
Member
There was a problem hiding this comment.
Everything looks good except the CI. Once that's fixed, I'm ready to approve.
ddbaptiste
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR streamlines CMake to match RESPOND and helps make the presets more intuitive by name. Additionally, we add in Windows building.
What Wrike task is this associated with?
N/A, caused by Ryon's need
Checklist before merging