Skip to content

Let users type or slide the check timeout - #43

Merged
nihey merged 1 commit into
mainfrom
check-timeout-type-or-slider
Sep 15, 2026
Merged

nihey merged 1 commit into
mainfrom
check-timeout-type-or-slider

Conversation

@nihey

@nihey nihey commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Create and edit check dialogs now share a timeout control with both a seconds input and a slider.
  • Values stay in sync, clamp to 1–60 seconds, and still submit as milliseconds.

Validation

  • Added or updated tests for behavior changes
  • Ran relevant tests and checks
  • Updated relevant documentation
  • Confirmed no production data, credentials, or populated .env files are included

Checklist

  • Conventional commit subject used
  • Scope is focused and ready for review

Test plan

  • Open New check, choose HTTP or TCP, type a timeout in seconds and confirm the slider moves
  • Drag the timeout slider and confirm the number field updates
  • Edit an existing HTTP/TCP check and confirm both controls work the same way
  • Values outside 1–60s clamp on blur

Create was slider-only and edit was a millisecond input; both now share a seconds field plus slider so the timeout can be set either way.
@nihey
nihey merged commit cd60f18 into main Sep 15, 2026
11 of 12 checks passed
@nihey
nihey deleted the check-timeout-type-or-slider branch September 15, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant