Skip to content

Let users type or slide period, grace, and interval on create - #44

Merged
nihey merged 1 commit into
mainfrom
feat/type-or-slide-create-durations
Sep 16, 2026
Merged

nihey merged 1 commit into
mainfrom
feat/type-or-slide-create-durations

Conversation

@nihey

@nihey nihey commented Sep 16, 2026

Copy link
Copy Markdown
Member

Summary

  • New check Period, Grace, and Interval now share Timeout's seconds field plus slider, so heartbeat and probe times can be typed instead of slider-only.
  • The duration field keeps an out-of-range draft while typing and clamps on blur, so a plan floor like 300s does not block entering 600.

Validation

  • Added or updated tests for behavior changes
  • Ran relevant tests and checks
  • Updated relevant documentation
  • Confirmed no production data, credentials, or populated .env files are included

Checklist

  • Conventional commit subject used
  • Scope is focused and ready for review

Test plan

  • Open New check as Heartbeat: type Period and Grace, confirm slider follows, then drag the slider
  • Type a Period below the plan floor, blur, confirm it clamps to the floor
  • Switch to HTTP: type Interval and Timeout
  • Cron heartbeat still has a typeable Grace field

Create used slider-only duration fields, so heartbeat and probe times could not be typed; they now share the timeout seconds-plus-slider control and keep out-of-range drafts until blur.
@nihey
nihey merged commit 5ac711b into main Sep 16, 2026
8 checks passed
@nihey
nihey deleted the feat/type-or-slide-create-durations branch September 16, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant