feat: auto-detect the solution root instead of trusting the wire parameter - #102
Open
zekelinAlex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the concept of tools-devkit-templates#127 into the library as one more helper: SolutionRootLocator resolves the unpacked solution root from the working directory - Other/Solution.xml at the base itself, the csproj SolutionRootPath property, or a unique nested Other/Solution.xml.
The dispatcher now treats the wire solution-root value as a hint at best: an existing directory is honored (programmatic callers, tests), anything else triggers detection. Templates and the CLI don't have to pass a real path anymore - the option is already gone from apply-scaffold. Stacked on the flow applier PR.