feat: app security role scaffold applier for pp-app-security-role - #114
Open
zekelinAlex wants to merge 1 commit into
Conversation
zekelinAlex
force-pushed
the
users/alexander.zekelin/applier-pp-security-role-privilege
branch
from
September 17, 2026 16:46
a75da0e to
3572c89
Compare
zekelinAlex
force-pushed
the
users/alexander.zekelin/applier-pp-app-security-role
branch
from
September 17, 2026 16:46
1286768 to
e9d17f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pp-app-security-role's old AddRoles call never worked: the script looked up a null AppModuleRoleMaps node, crashed, and wiped the maps it was supposed to fill. the applier builds the new node before the old one is removed (same semantics as the TALXIS/tools-devkit-templates#152 fix), takes role ids bare, braced or quoted, rejects non-guids, and writes braced guids with #152's writer settings (indent, utf8 no bom). dispatcher key AppSecurityRole.
parity sandbox: the AppModuleRoleMaps with both role guids exists only in the updated run because the baseline call never worked, the baseline keeps the render stub with its placeholder role. the rest of the diff is the differ's guid renumbering plus the same node repositioning the fixed #152 script produces.
stacked on the security-role-privilege applier.