pp-security-role: single apply-scaffold post-action - #162
Closed
zekelinAlex wants to merge 1 commit into
Closed
zekelinAlex wants to merge 1 commit into
zekelinAlex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same treatment as #147 for pp-security-role. The two scripts collapse into one ApplyScaffold.ps1 calling txc workspace component apply-scaffold with component type SecurityRole, the generated role id passed as role-id.
Sandbox parity vs the old scripts is clean - the only diff left is Solution.xml's xsi:nil tags going back to the template's own single-line form (the old script's XmlDocument.Save expanded them on every rewrite).
Needs the SecurityRole applier from TALXIS/platform-metadata#96 and the CLI command from TALXIS/tools-cli#187, so don't merge before those ship.