chore: remove unused legacy code - #15
Merged
Merged
Conversation
Remove the empty StationLoader (with its unused field, import and commented-out load call), the empty StationData, the unused CraftingGUI and RecipeType, and commented-out debug output in CraftingStation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes placeholder classes and commented-out code that nothing in the plugin or the other TF-Minecraft repositories uses.
loaders/StationLoader.java: an empty class. Its only use was the unusedstationLoaderfield inAdvancedCrafting, which is removed together with its import and the commented-outstationLoader.load("stations.yml")call.objects/data/StationData.java: an empty class.objects/crafting/CraftingGUI.java: fields only, never instantiated.enums/RecipeType.java: never referenced.CraftingStationthat printed ingredient and hit progress.LegacyModelDataandSOURCE.mdare unchanged.Validation: searched the repository (including YAML and string or reflective uses) and every sibling TF-Minecraft repository for each removed name. Thievery and Recycler import other classes from
objects.dataandloaders, but none of the removed ones. The similarly namedStationLoaderandStationDataclasses in other plugins are unrelated. Imports in the touched files were re-checked;git diff --checkpasses. The standard PR build is the compile and test gate.🤖 Generated with Claude Code