fix: refuse branding a station without a recipe - #20
Conversation
Left-clicking a station with the branding tool before choosing a recipe called craft() with a null recipe and threw a NullPointerException. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe branding tool crafting flow now checks whether the station has a recipe. If it does not, the player receives a selection prompt and failure sound, and crafting stops. ChangesBranding tool crafting
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change prevents branding without a selected recipe from reaching the failing craft call. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit checks the recipe first, Comment |
Summary
Left-clicking a crafting station with the branding tool before a recipe is chosen called
craft()with a null recipe. It threw aNullPointerException(seen on TFMCMain 2026-09-23 20:37). The player now gets "No recipe on this station. Select a recipe first."Verification
mvn packagebuilds.🤖 Generated with Claude Code
Summary by CodeRabbit