Skip to content

ci: pin shared plugin setup to TLibs main - #21

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin TF-Minecraft/TLibs/.github/actions/setup-plugins to 8ef41de on TLibs main. The previous pin, 4f7a354, is the head of TLibs PR ci: enable CodeRabbit approving reviews #19 and is not on any branch (ci: enable CodeRabbit approving reviews #19 was squash-merged as 8f48e6f). The action itself is unchanged; since then the installer has only dropped its unused --assets option and added GemInfusion to its catalogue.
  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated build and release automation configuration.

The setup-plugins action was pinned to 4f7a354, the head of TLibs PR #19,
which is not on any TLibs branch. Pin it to 8ef41de on TLibs main. The
action is unchanged; its installer catalogue now also lists GemInfusion.

Drop -P'!deploy-live'. No POM defines a deploy-live profile, so the flag
does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: da4c125e-0b22-4202-a90b-effe12767d35

📥 Commits

Reviewing files that changed from the base of the PR and between 689e0ea and bc18b8a.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Both workflows now use a newer pinned revision of the shared-plugin setup action. Their version-setting, artifact-name evaluation, and clean verify commands no longer explicitly disable the deploy-live profile.

Changes

Workflow updates

Layer / File(s) Summary
Plugin setup and Maven commands
.github/workflows/build.yml, .github/workflows/maven-release.yml
Both workflows use the updated setup action commit. The listed Maven commands no longer pass -P'!deploy-live'.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bc18b

No repository-defined deploy-live profile is present to change these Maven commands, and no concrete merge-blocking effect is established. The updated setup-action pin was confirmed to exist.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the primary change: pinning the shared plugin setup to TLibs main. It is related to both workflow changes and uses specific terminology.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the workflow trail,
New pinned commits now set the sail.
Maven runs without that flag,
The build steps follow a tidier track.
I nibble clover, pleased to see.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 16e36d0 into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant