fix: keep mixing bowl flour and yeast stars when the last item is used

[Drefvelin]

Summary

• Read flour and yeast quality before the held stack is reduced, so the last item in hand still contributes its stars to the dough.
• Water still has no quality, and sugar and fruit were already recorded before their stacks shrank.

Documentation impact

• Central Cooking documentation: no change

Contract

• Affected behavior: mixing bowl dough quality when flour or yeast is the last item in the stack
• Tests run (mvn test, or why not): not run locally; this is event-handler ordering around Bukkit item stacks
• Player wiki (ProvinceSystem /wiki/cooking or related pages): no change

Notes

• Config source is src/main/resources. Do not edit target/.
• plugin.yml version and pom.xml version are known drift. Do not mix a version bump into unrelated work.
• cookware.yml is not loaded.

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
  • Flour and yeast additions are now rejected if the held item cannot be recognized as a food ingredient.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 249db329-053c-4732-a621-55cd5d01239c

📥 Commits

Reviewing files that changed from the base of the PR and between bc59526 and 3e97226.

📒 Files selected for processing (1)

• src/main/java/net/tfminecraft/cooking/mixing/MixingBowlHandler.java

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

The mixing bowl handler now retains the parsed flour or yeast FoodItem. It rejects additions when parsing fails and passes the parsed item to quality storage.

Changes

Mixing Bowl Ingredient Handling

Layer / File(s)	Summary
Parse and store ingredients src/main/java/net/tfminecraft/cooking/mixing/MixingBowlHandler.java	handleIngredientAdd retains the parsed FoodItem and rejects the addition if parsing fails. storeIngredientQuality receives that item directly instead of parsing the held ItemStack internally.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 3e972

Flour and yeast quality metadata is retained when the last item in a stack is added. No actionable merge risk was identified in the reviewed change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the primary fix: preserving flour and yeast quality when the final item in the held stack is used.
Description check	✅ Passed	The description includes all required template sections. It explains the behavior change, documentation impact, affected behavior, test status, wiki impact, and repository notes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{I watched the flour meet the yeast,
A parsed ingredient, ready for the feast.
The bowl now keeps the item in view,
And stores its quality from that cue.
I twitch my nose, then hop away,
With mixing done for today.}

_{Comment @coderabbitai help to get the list of available commands.}