Skip to content

Let dough rise through three quality stages - #40

Merged
Drefvelin merged 1 commit into
mainfrom
feat/dough-rising
Sep 24, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
feat/dough-rising

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Dough now proofs on a rising tag: unrisen is −3 stars, rising is −1, and risen keeps the inherited ingredient stars.
  • The new models are unrisen, rising, and risen. Mouldy dough (the rotten state) uses one model, and its item name is Mouldy Dough.
  • Full rise takes 15 minutes (the rising look starts at 5). Baking uses the stars from the current stage and does not keep the rising tag on the loaf.

Test plan

  • Knead dough and confirm it starts Unrisen at three stars below the flour and yeast.
  • Wait 5 minutes and confirm the rising model and a one-star penalty.
  • Wait 15 minutes and confirm the risen model keeps the inherited stars.
  • Leave dough until it spoils and confirm a single mouldy model labelled Mouldy.
  • Bake at each stage and confirm the loaf stars match that stage and the loaf is not tagged Unrisen, Rising, or Risen.
  • Do not reload the ItemsAdder pack as part of this change.

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Dough now progresses through unrisen, rising, and risen stages, with distinct appearances and proofing times.
    • Quality stars change as dough rises and are reflected in displayed quality and food effects.
    • Baking uses the dough’s current effective quality, while proofing progress does not carry over to the loaf.
  • Updates
    • “Dough Rotten” is now labeled “Mouldy Dough,” with an updated appearance.

Unrisen dough sits three stars below its ingredients, rising dough one star below, and risen dough keeps the inherited stars. Mouldy dough uses a single model.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ff4e2ede-3a59-42ce-b81f-1f834cbb687a

📥 Commits

Reviewing files that changed from the base of the PR and between 49dbdd0 and f21a686.

⛔ Files ignored due to path filters (15)
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_mouldy_main.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_mouldy_side.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_mouldy_side_2.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_mouldy_side_3.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_risen_main.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_risen_side_2.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_risen_side_3.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_rising_main.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_rising_side_1.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_rising_side_2.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_rotten.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_unrisen_main.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_unrisen_side_1.png is excluded by !**/*.png
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/textures/item/bulk/dough_unrisen_side_2.png is excluded by !**/*.png
📒 Files selected for processing (23)
  • ItemsAdder/tfmc_cooking/contents/categories.yml
  • ItemsAdder/tfmc_cooking/contents/intermediates.yml
  • ItemsAdder/tfmc_cooking/contents/items.yml
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/models/item/bulk/dough.json
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/models/item/bulk/dough_mouldy.json
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/models/item/bulk/dough_risen.json
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/models/item/bulk/dough_rising.json
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/models/item/bulk/dough_rotten.json
  • ItemsAdder/tfmc_cooking/resourcepack/assets/tfmc_cooking/models/item/bulk/dough_unrisen.json
  • src/main/java/net/tfminecraft/cooking/baking/BakingTrayHandler.java
  • src/main/java/net/tfminecraft/cooking/baking/BakingTrayTransform.java
  • src/main/java/net/tfminecraft/cooking/item/FoodItem.java
  • src/main/java/net/tfminecraft/cooking/item/tag/TagQuality.java
  • src/main/java/net/tfminecraft/cooking/item/tag/TagStep.java
  • src/main/java/net/tfminecraft/cooking/quality/CompositionQualityResolver.java
  • src/main/java/net/tfminecraft/cooking/utils/DisplayUtils.java
  • src/main/java/net/tfminecraft/cooking/utils/DoughRising.java
  • src/main/java/net/tfminecraft/cooking/utils/ItemBuilder.java
  • src/main/resources/conversions.yml
  • src/main/resources/models.yml
  • src/main/resources/tags.yml
  • src/main/resources/types.yml
  • src/test/java/net/tfminecraft/cooking/item/RisingDoughTest.java
 _____________________________________
< Please step away from the keyboard! >
 -------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit c2f115b into main Sep 24, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the feat/dough-rising branch September 24, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant