Skip to content

Scale breeding gene bonus by feed quality - #42

Merged
Drefvelin merged 1 commit into
mainfrom
feat/breed-feed-quality
Sep 24, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
feat/breed-feed-quality

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Breeding with wheat, carrots, and other cooking foods scales the offspring gene bonus by item stars: 1★ keeps 20% of the bonus and 5★ keeps the current roll.
  • Universal feed, and items with no cooking quality, still pass on the full bonus. The two parents' feeds are averaged.

Documentation impact

Contract

  • Affected behavior: offspring genetics when parents are bred with star-rated food. Care 0 still leaves the child at the parent average. Five-star food matches the previous formula.
  • Tests run: mvn -P'!deploy-live' -Dtest=HusbandryGeneticsTest,HusbandryFeedQualityTest test
  • Player wiki (ProvinceSystem /wiki/cooking or related pages): no change

Notes

  • Config source is src/main/resources. Do not edit target/.
  • plugin.yml version and pom.xml version are known drift. Do not mix a version bump into unrelated work.
  • cookware.yml is not loaded.

Test plan

  • CI snapshot build (DEV-YYYYMMDD-HHmm) succeeds
  • Dev server starts with that snapshot jar and Cooking enables
  • 5★ wheat breeds like today; 1★ wheat yields a smaller gene bump; universal feed stays a full bonus

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Breeding outcomes now reflect the quality of food offered to animals. Higher-quality feed can increase the genetics boost, while low-quality feed reduces it.
    • Universal feed and items without a cooking-quality rating count as full-quality feed.

Lower-star wheat, carrots, and other breeding food pass on less of the gene bump. Five-star food and universal feed keep the current roll.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 13035cf2-8f15-46e9-a4a2-cc1dd4d3b407

📥 Commits

Reviewing files that changed from the base of the PR and between 94a35d8 and 17e31ce.

📒 Files selected for processing (6)
  • src/main/java/net/tfminecraft/cooking/husbandry/HusbandryBreedListener.java
  • src/main/java/net/tfminecraft/cooking/husbandry/HusbandryFeedQuality.java
  • src/main/java/net/tfminecraft/cooking/husbandry/HusbandryGenetics.java
  • src/main/resources/husbandry.yml
  • src/test/java/net/tfminecraft/cooking/husbandry/HusbandryFeedQualityTest.java
  • src/test/java/net/tfminecraft/cooking/husbandry/HusbandryGeneticsTest.java
 ________________________________________________________________________
< Making the Death Star fully operational, with zero exhaust port flaws. >
 ------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 7f62052 into main Sep 24, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the feat/breed-feed-quality branch September 24, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants