fix: build releases as the stable branch - #13
Merged
Merged
Conversation
The development branch value made release builds report a -development edition, so Patch skipped the database upgrade scripts on existing databases. Release builds now carry an empty branch, matching upstream stable releases, so the 2.25.0 upgrade runs on first start. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release builds set
<project.branch>development</project.branch>, whichplugin.ymlexposes asbranch.VersionUtils.getBranch()turns that into-development, andPatch.java(around line 247) skips every database patch script when the edition branch contains-dev. On an existing 24.0 database, v25.0.0 therefore never applies the 2.25.0 upgrade: the new message-search indexes are missing, and on MySQLentity.datais not widened.This clears the property, matching upstream stable releases, so the upgrade runs on first start after an upgrade from 24.0. The value was introduced in 5525a82 and nothing else reads it.
Validation:
project.branchis only referenced byplugin.yml; an empty value makesgetBranch()return an empty string. The standard build must pass before merge.🤖 Generated with Claude Code