Skip to content

fix: allow CoreProtect startup with an empty build branch - #15

Merged
ryanbarlow97 merged 1 commit into
masterfrom
fix/allow-empty-build-branch
Sep 23, 2026
Merged

ryanbarlow97 merged 1 commit into
masterfrom
fix/allow-empty-build-branch

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

CoreProtect 25.0.2 disabled itself on startup because the inherited version cap rejects builds newer than 24.0 without a development branch. An additional check also rejected the empty branch used by our release builds.

Remove both build restrictions so release JARs can start with an empty project.branch. Minecraft and Java compatibility checks remain in place.

Validation: Maven verify passed with tests enabled (the repository contains no tests); generated plugin.yml retains an empty branch; git diff --check passed. Live server startup has not been tested.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 12b61d2a-f66b-4190-8d64-60f50aa62f95

📥 Commits

Reviewing files that changed from the base of the PR and between cd8fc6f and 99cf297.

📒 Files selected for processing (1)
  • src/main/java/net/tfminecraft/coreprotect/services/VersionCheckService.java
 ___________________________________________________________________
< Your commit message says 'quick fix'. That's how folklore starts. >
 -------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit b1944ba into master Sep 23, 2026
1 of 2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/allow-empty-build-branch branch September 23, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant