Skip to content

chore: remove legacy CI flag and upstream contribution leftovers - #16

Merged
ryanbarlow97 merged 2 commits into
masterfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 2 commits into
masterfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.
  • CONTRIBUTING.md: send discussion and code-of-conduct reports to the TFMC Discord rather than PlayPro's, name the upstream, and drop the claim that contributions are automatically analysed. The Contributor Covenant text and attribution are unchanged.
  • Remove upstream's .github/FUNDING.yml (Patreon) and .github/stale.yml (stale-bot config).

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Builds
    • Maven build and release checks now use the default activation behavior for the deploy-live profile.
  • Repository Updates
    • Automatic issue staleness labeling and closure are no longer configured.
    • The repository’s funding listing was removed.
  • Documentation
    • Contribution guidance now identifies the TFMC fork, updates where to discuss contributions and suggest guideline changes, and points conduct reports to the TFMC Discord.

ryanbarlow97 and others added 2 commits September 24, 2026 20:45
No POM defines a deploy-live profile, so -P'!deploy-live' does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
CONTRIBUTING.md sent contributors and code-of-conduct reports to
PlayPro's Discord and promised automatic analysis this fork does not
run. Use the TFMC Discord and issues instead, and name the upstream.

Remove upstream's Patreon funding link and stale-bot configuration;
neither applies to this repository.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0182c212-5f5b-4912-a16c-b5f9e77a1ed0

📥 Commits

Reviewing files that changed from the base of the PR and between b1944ba and 54fa4bf.

📒 Files selected for processing (5)
  • .github/FUNDING.yml
  • .github/stale.yml
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml
  • CONTRIBUTING.md
💤 Files with no reviewable changes (2)
  • .github/FUNDING.yml
  • .github/stale.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request removes two GitHub repository entries, changes Maven profile selection in build workflows, and updates contribution and code-of-conduct guidance.

Changes

Funding entry

Layer / File(s) Summary
Remove Patreon entry
.github/FUNDING.yml
The file no longer lists the Patreon entry for coreprotect.

Stale issue configuration

Layer / File(s) Summary
Remove stale-issue configuration
.github/stale.yml
The stale timing, exempt labels, label, and comments configuration is removed.

Maven workflow profile selection

Layer / File(s) Summary
Use default profile selection
.github/workflows/build.yml, .github/workflows/maven-release.yml
The listed Maven commands no longer explicitly deactivate the deploy-live profile.

Contributor guidance

Layer / File(s) Summary
Update contribution and conduct guidance
CONTRIBUTING.md
The guide identifies the TFMC fork, updates discussion and guideline-suggestion directions, and revises code-of-conduct reporting details.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 54fa4

The repository cleanup and guidance changes have no established merge-blocking issue. Normal workflow checks remain appropriate.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main changes: removing the legacy Maven CI flag and cleaning up upstream contribution and repository configuration leftovers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit reads the updated page,
Then hops along past stale-work age.
Maven keeps its profiles near,
New guidance makes the path more clear.
I nibble clover, pleased to see,
These tidy changes set things free.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit e5008ad into master Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant