Gate rune keybind casts by weapon attunement - #25
Merged
Merged
Conversation
Right-click and shift-click rune abilities were ignored because the cast listener only watched CAST and API. Those keybinds are already listed in config, so the listener now treats every configured trigger as a cast. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Drefvelin
pushed a commit
that referenced
this pull request
Sep 24, 2026
The same "magic update" commit also dropped the spell side of the first commit. Bring back: - Spell tier gates. skills.yml tier is the floor for both the weapon's band and the caster's resonance, with separate weapon and spell refusal lines. - /magic rune keybind <trigger> to rebind a held rune's abilities, with the magic.rune.keybind permission and runes.types config. - Element permissions. Locked schools stay hidden in the resonance menu, do not grow, and are skipped by admin resonance commands. - The cast mode switch chat line and "Click to Select" hint. The runes section merges with the cast triggers from #25. Element names keep the gradient colouring from #26. The per-cast durability debug log is not restored. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Drefvelin
added a commit
that referenced
this pull request
Sep 24, 2026
) * fix: restore gear crafting lost in the magic update The 2026-09-20 "magic update" commit was pushed from an older copy and dropped the gear work from the first commit: sneak-left-click craft abort with refunds, core part-limit slots, part stats, tiers, model schemes, the socket rarity prefix toggle, and the post-charge chat summary. Live gear configs still use all of these keys. Bring that code back on top of current main, keeping the TLibs package move, hidden unchargeable elements, and the spell modifier resync after charging. The gear station is also protected from ItemsAdder breaks while it holds a weapon, runs orbs, or has just been aborted, since orb hits and aborts are swings that ItemsAdder treats as a furniture break. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: avoid deprecated stat history and model data calls in gear Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: restore spell tiers, rune keybinds and resonance locks The same "magic update" commit also dropped the spell side of the first commit. Bring back: - Spell tier gates. skills.yml tier is the floor for both the weapon's band and the caster's resonance, with separate weapon and spell refusal lines. - /magic rune keybind <trigger> to rebind a held rune's abilities, with the magic.rune.keybind permission and runes.types config. - Element permissions. Locked schools stay hidden in the resonance menu, do not grow, and are skipped by admin resonance commands. - The cast mode switch chat line and "Click to Select" hint. The runes section merges with the cast triggers from #25. Element names keep the gradient colouring from #26. The per-cast durability debug log is not restored. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: tie gear aborts to the preparer and what they paid Anyone could abort another player's prepared craft and take its material refund, and cost-bypass players got refunds for materials never taken. Stations now record who prepared the craft and the exact materials charged. Only that player (or an admin) can abort it, and the refund is what was paid. Stations saved before this keep the old behaviour. Also break model-scheme ties between the tied leaders only, and fix the "Ascendant Rune" suffix, the petty_tome3 id and two lore typos in the bundled gear defaults. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Ryan <7389646+ryanbarlow97@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CASTandAPIas spells, so a rune set to right-click, left-click, or shift-click fired even when the weapon was not attuned to that element.runes.keybindsinconfig.ymlis now loaded on startup and reload. Those triggers, plusCASTandAPI, go through the same refusal, rift, and overload checks. Equilibrium drift follows the same set.Test plan
Cast triggers: CAST, API, RIGHT_CLICK, LEFT_CLICK, SHIFT_RIGHT_CLICK, SHIFT_LEFT_CLICKon a server whose config already lists those keybinds./magic reloadafter editingrunes.keybindspicks up the new list.Made with Cursor
Summary by CodeRabbit