chore: remove unused gson dependency and abandoned quest stubs - #20
Merged
Merged
Conversation
Nothing imports com.google.gson. It was the only private JAR, so prepare-release.sh becomes the standard no-private-JARs stub and the checksum file and install script go. The quest feature was never wired: QuestLoader is empty, quests.yml and quest-tiers.yml are never saved or loaded, and MBGUI.QUEST is never constructed or matched. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove an unused build input and the never-wired quest feature.
Gson. Nothing in
srcimports or namescom.google.gson, so thelocal:gson:2.10.1dependency is removed frompom.xml. It was the only private JAR, soprepare-release.shnow uses the same no-private-JARs stub as PermCleaner and WorldBorder.install-local-dependencies.shand.github/dependencies.sha256are deleted; leaving an empty checksum file would makesha256sum --checkfail. The workflows still callprepare-release.shunchanged.Quest stubs. Removed
loader/QuestLoader.java(an empty class),quests.yml,quest-tiers.ymland theMBGUI.QUESTconstant.MarketBlockonlysaveResources and loadsconfig.yml,categories.ymlandtrades.yml, and no code reads the quest keys.QUESTis never constructed or matched. Both switches overMBGUIinTradeManagerare statements that handleCATEGORYandTRADEand fall through todefault.valueOforname()onMBGUI, andMBHolderonly lives in memory as anInventoryHolder, so no enum names are persisted.Validation: searched the repository (including resources and workflows) and the wider TF-Minecraft workspace for
gson,quest,QuestLoader,MBGUIand the quest YAML keys. The only external mention is the ProvinceSystem wiki research note, which already records that the quest feature is inert. CI build is the gate.No deployment or release publication is included.
🤖 Generated with Claude Code