chore: pin CI to TLibs main and remove completed TODOs - #33
Merged
Merged
Conversation
The setup-plugins action was pinned to 4f7a354, the head of TLibs PR #19, which is not on any TLibs branch. Pin it to 8ef41de on TLibs main. The action is unchanged; its installer catalogue now also lists GemInfusion. Drop -P'!deploy-live'. No POM defines a deploy-live profile, so the flag does nothing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The mercenary company trait gate is implemented and enabled whenever RPCharacters is present. The bundled war.yml already requires declare codes, so only the live-config check remains. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TF-Minecraft/TLibs/.github/actions/setup-pluginsto8ef41deon TLibsmain. The previous pin,4f7a354, is the head of TLibs PR Unify plugin artifact naming, validation, and ignore rules #19 and is not on any branch (Unify plugin artifact naming, validation, and ignore rules #19 was squash-merged as8f48e6f). The action itself is unchanged; since then the installer has only dropped its unused--assetsoption and added GemInfusion to its catalogue.-P'!deploy-live'from the Maven commands. No POM defines adeploy-liveprofile, so the flag does nothing.TODO.md: remove the mercenary trait gate, which is implemented (MercenaryEligibilitywithRpCharactersMercenaryTraitProbe). The bundledwar.ymlalready setsrequire_declare_code: true, so only the live-config check stays.Verification
🤖 Generated with Claude Code