Skip to content

Let guild leaders kick members - #35

Merged
Drefvelin merged 1 commit into
mainfrom
guild-kick
Sep 24, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
guild-kick

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Guild leaders can remove a member with /guild kick <player>. The member is taken off the guild the same way /guild leave does, including dropping them from the faction when they are not in the base guild.
  • The base guild still uses /faction kick. The leader cannot kick themselves, and tab completion lists the other members.

Test plan

  • mvn -Dtest=GuildKickCommandTest test (leader kick, non-leader, base guild, self-kick, unknown name, tab completion)
  • Dev CI build on this pull request succeeds
  • On a server: as a sub-guild leader, /guild kick <member> removes them and tells them; /guild kick on the base guild points at /faction kick

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Guild leaders can remove members from their guilds with /guild kick <player>. The removed member is notified, and leaders cannot kick themselves or members of base guilds.
    • Tab completion suggests eligible guild members for the kick command.
  • Bug Fixes
    • The command rejects attempts to kick players who are not guild members.

Sub-guild leaders could invite members, but only the member could leave.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 67be681f-0cd8-44ed-9984-d9785bc81244

📥 Commits

Reviewing files that changed from the base of the PR and between dc6ad3c and 51f0d55.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/simplefactions/managers/CommandManager.java
  • src/main/java/net/tfminecraft/simplefactions/utils/TabCompletion.java
  • src/test/java/net/tfminecraft/simplefactions/guild/GuildKickCommandTest.java
 ____________________________________________________________________
< There is a 100% chance that this message is relevant to your code. >
 --------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 4d60d9f into main Sep 24, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the guild-kick branch September 24, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant