Conversation
tolauwae
force-pushed
the
nanopb
branch
2 times, most recently
from
August 30, 2026 07:37
0f826c5 to
b6258dd
Compare
Member
|
Oh wow the Zephyr binary size is actually slightly smaller than the current size on main. |
MaartenS11
reviewed
Sep 1, 2026
| } | ||
|
|
||
| this->dumpHeapInfo(m); | ||
| void Debugger::dump(Module *m, bool) const { snapshot(m); } |
Member
There was a problem hiding this comment.
Makes me wonder, should we still even have dump since it's the same as snapshot? Command dump and command snapshot are just the same at this point, might be good to just remove one now.
MaartenS11
reviewed
Sep 1, 2026
| } | ||
|
|
||
| void Debugger::checkpoint(Module *m, const bool force, const bool full) { | ||
| void Debugger::checkpoint(Module *, const bool force, const bool) { |
Member
There was a problem hiding this comment.
Support for full seems to have gone missing here (just putting that here so we don't forget).
MaartenS11
reviewed
Sep 1, 2026
| endIdx++; | ||
| namespace { | ||
|
|
||
| bool decodeFrameLength(const std::vector<uint8_t> &bytes, size_t *headerSize, |
Member
There was a problem hiding this comment.
Would be nice to have some comments/documentation of how this works.
MaartenS11
reviewed
Sep 1, 2026
Comment on lines
+544
to
+550
| functionBodies[update.function_index] = std::move(instructions); | ||
| Block &function = m->functions[update.function_index]; | ||
| function.start_ptr = functionBodies[update.function_index].data(); | ||
| function.end_ptr = function.start_ptr + | ||
| functionBodies[update.function_index].size() - 1; | ||
| function.br_ptr = function.end_ptr; | ||
| sendOperationResult(message->type, true); |
Member
There was a problem hiding this comment.
Seems a bit strange to have functionBodies as a field in the Debugger but maybe it's used somewhere else that I'm not aware of.
tolauwae
force-pushed
the
nanopb
branch
3 times, most recently
from
September 2, 2026 13:07
49e9d78 to
e8a4b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the existing debugger API using a protobuf scheme. The new scheme his optimized for low message size.
protobuf scheme
Protobuf defines two message type enums:
For instance:
Payloads are defined in protobuf as messages. For instance:
Debug messages are not fully encoded by protobuf, only these payload.
This means that debug messages are of this form:
This allows for minimal message size. Sending message looks like this:
Which results in this message on the wire:
ABI improvements