Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/discord-notification.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,26 @@ on:

jobs:
notify:
permissions: {}
permissions:
pull-requests: write
issues: write
runs-on: ubuntu-latest

steps:
- name: Remove reminded label after review
if: github.event_name == 'pull_request_review' && github.event.action == 'submitted'
env:
GH_TOKEN: ${{ github.token }}
run: |
if ! output=$(gh pr edit "${{ github.event.pull_request.number }}" --repo "${{ github.repository }}" --remove-label "🫵🏻 Reminded" 2>&1); then
if echo "$output" | grep -qi "not found"; then
echo "Label not present, skipping: $output"
else
echo "$output" >&2
exit 1
fi
fi

- name: Send Detailed Discord Message
shell: bash
env:
Expand Down
144 changes: 144 additions & 0 deletions .github/workflows/discord-reviewer-reminder.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
name: ⏰ Discord Reviewer Reminder

on:
schedule:
- cron: '0 1,6 * * 1-5' # 평일 KST 10:00, 15:00
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}
cancel-in-progress: false

jobs:
remind:
permissions:
pull-requests: write
issues: write
runs-on: ubuntu-latest
Comment thread
kimminna marked this conversation as resolved.

steps:
- name: Remind pending reviewers
uses: actions/github-script@v7
env:
DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_REMINDER_WEBHOOK_URL }}
with:
script: |
const REMINDER_THRESHOLD_HOURS = 24;
const REMINDED_LABEL = '🫵🏻 Reminded';

const NAME_MAP = {
kimminna: '민아',
ehye1: '혜원',
jjangminii: '정민',
'yumin-kim2': '유민',
};
const resolveName = (login) => NAME_MAP[login] || login;

const webhookUrl = process.env.DISCORD_WEBHOOK_URL;
if (!webhookUrl) {
console.log('DISCORD_REMINDER_WEBHOOK_URL not set, skipping');
return;
}

const pulls = await github.paginate(github.rest.pulls.list, {
owner: context.repo.owner,
repo: context.repo.repo,
state: 'open',
per_page: 100,
});

const now = Date.now();
const failedPrs = [];

for (const pr of pulls) {
if (pr.draft) continue;

const labels = pr.labels.map((label) => label.name);
if (labels.includes(REMINDED_LABEL)) continue;

const reviewers = pr.requested_reviewers ?? [];
const teams = pr.requested_teams ?? [];
if (reviewers.length === 0 && teams.length === 0) continue;

const timelineEvents = await github.paginate(github.rest.issues.listEventsForTimeline, {
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pr.number,
per_page: 100,
});

const reviewRequestTimes = new Map();
for (const event of timelineEvents) {
if (event.event !== 'review_requested') continue;
const login = event.requested_reviewer?.login;
if (login) {
reviewRequestTimes.set(`user:${login}`, event.created_at);
continue;
}
const teamSlug = event.requested_team?.slug;
if (teamSlug) {
reviewRequestTimes.set(`team:${teamSlug}`, event.created_at);
}
}

const requestTimestamps = [
...reviewers.map((reviewer) => reviewRequestTimes.get(`user:${reviewer.login}`)),
...teams.map((team) => reviewRequestTimes.get(`team:${team.slug}`)),
]
.filter(Boolean)
.map((timestamp) => new Date(timestamp).getTime());

const oldestRequestTime =
requestTimestamps.length > 0 ? Math.min(...requestTimestamps) : new Date(pr.created_at).getTime();

const hoursOpen = (now - oldestRequestTime) / (1000 * 60 * 60);
if (hoursOpen < REMINDER_THRESHOLD_HOURS) continue;

const reviewerNames = [
...reviewers.map((reviewer) => resolveName(reviewer.login)),
...teams.map((team) => team.name || team.slug),
].join(', ');

const payload = {
embeds: [
{
title: '⏰ 리뷰 리마인드',
url: pr.html_url,
description: `**${pr.title}**\n리뷰 요청 후 ${Math.floor(hoursOpen)}시간째 대기 중이에요.`,
color: 16776960,
fields: [{ name: '리뷰어', value: reviewerNames, inline: true }],
footer: { text: 'GitHub Actions' },
timestamp: new Date().toISOString(),
},
],
};

try {
const response = await fetch(webhookUrl, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(payload),
signal: AbortSignal.timeout(10000),
});

if (!response.ok) {
console.error(`Discord webhook failed for PR #${pr.number}: ${response.status}`);
failedPrs.push(pr.number);
continue;
}
Comment on lines +124 to +128

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!response.ok) {
console.error(`Discord webhook failed for PR #${pr.number}: ${response.status}`);
failedPrs.push(pr.number);
continue;
}
if (!response.ok) {
console.error(`Discord webhook failed for PR #${pr.number}: ${response.status}`);
failedPrs.push(pr.number);
continue;
}
await github.rest.issues.addLabels({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pr.number,
labels: [REMINDED_LABEL],
});
} catch (error) {
console.error(`Failed to process PR #${pr.number}: ${error.message}`);
failedPrs.push(pr.number);
}

webhook은 이미 성공적으로 보냈는데 라벨 추가만 실패한 경우, 다음 실행에서 같은 PR에 대해 또 알림이 갈 수 있을 것 같아요. 라벨 추가 실패를 별도로 catch해서 로그만 남기고 "이미 알림은 보냈다"는 걸 구분하거나, 최소한 로그 메시지에 "webhook은 성공, 라벨 추가만 실패"라고 명시하면 디버깅에 도움될 것 같아요-!


await github.rest.issues.addLabels({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: pr.number,
labels: [REMINDED_LABEL],
});
} catch (error) {
console.error(`Failed to process PR #${pr.number}: ${error.message}`);
failedPrs.push(pr.number);
}
}

if (failedPrs.length > 0) {
console.error(`Failed to fully process PRs: ${failedPrs.join(', ')}`);
}
Loading