fix(membership): let Qgiv embed height flex on membership/supporting-member - #528
Merged
Conversation
The 720px max-height clipped taller variants of the Qgiv form; letting the iframe follow Qgiv's own resize behavior fixes both /membership and /supporting-member since they share QgivJoin via LegacyJoinSection.
Deploying website with
|
| Latest commit: |
6c7ce53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd3d0a9e.website-aun.pages.dev |
| Branch Preview URL: | https://fix-qgiv-flexible-height.website-aun.pages.dev |
… unbounded 720px clipped taller form variants; removing the cap entirely left Qgiv's unresized 1000px default showing as dead space. 950px splits the difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-height: 720pxCSS cap on the Qgiv payment iframe inQgivJoin.tsx/membershipand/supporting-member(viaLegacyJoinSection), so both pages now let the form's height flex to its actual content instead of clipping/leaving dead space at a fixed heightTest plan
/membership, click "Become a member", reach the payment step, confirm the Qgiv form renders fully without clipping/supporting-member, repeat the same flow