Trap focus and handle Escape in all 5 modals Closes #26 - #40
Merged
telivity-otaip merged 3 commits intoSep 8, 2026
Merged
Conversation
…e, ligoogle, rolepanel modals
Builds on @pasanghilp-art's PR TelivityAI#40: keep a shared createFocusTrap, but wire open/close through trapModal/closeModal, fold Escape into the existing builder/drawer handler (instead of five duplicate listeners), and give all five modals role=dialog + aria-labelledby names. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Contributor
|
Maintainer follow-up pushed to this branch (thanks @pasanghilp-art — your trap + wiring stays as the base commit):
This should fully satisfy #26. Ready to merge from here; duplicate #41 closed. |
Extend TelivityAI#40 so Escape/focus-trap work with SR-safe page inerting, backdrop click-to-close, and a live Playwright keyboard pass (Tab wrap, Escape, backdrop, focus restore). Clear inert before restoring opener focus — browsers ignore focus() into inert trees. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Contributor
|
Follow-up on this branch (still credited to @pasanghilp-art as author of the base work):
Should fully cover #26 plus the three gaps from review. Ready to merge once CI finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shared createFocusTrapp helper,
wired into open/close for all 5 modals,
extended the Excape keydown handler,
note npm test passes with no regressions,
couldnt fully test live due to supabase access.