Skip to content

Fix to Ad-astra Space suit - #453

Open
AnonNautilus wants to merge 2 commits into
ThePansmith:1.20.1from
AnonNautilus:1.20.1
Open

AnonNautilus wants to merge 2 commits into
ThePansmith:1.20.1from
AnonNautilus:1.20.1

Conversation

@AnonNautilus

Copy link
Copy Markdown

Describe the PR
Closes #444
The space suit functions as expected on the moon

Screenshots
Screenshot 2026-08-25 at 10 55 55 AM

Additional context

The nukelist.js script inside the of kube_js/server_scripts calls for kubejs/startup_scripts\item.js and seems to to nuke the nbt data of the ad astra space suits items (Listed as "ad_astra:space_helmet", "ad_astra:space_suit" "ad_astra:space_pants", and "ad_astra:space_boots", are hit by the expression /^ad_astra:(space|netherite_space|jet_suit)_(helmet|suit|pants|boots)$/,).

I altered this line to say: /^ad_astra:(netherite_space|jet_suit)_(helmet|suit|pants|boots)$/,

Side note: This has the funny side effect of fixing the rendering of the suit on the player character per issue #437, who also directly saw the fix themself, so kudos to them.

This change actually causes a runoff problem, it brings back the original ad-astra recipe for the space helmet, space boots, and space leggings without using the mechanical crafter. This was fixed with a removal of all "minecraft:crafting_shaped" recipes inside of kubejs/server_scripts/key_mods/ad_astra.js for the items in question (also included in this pull request).

@AnonNautilus

Copy link
Copy Markdown
Author

Oh also closes #437

@ChrisLane

Copy link
Copy Markdown

@ThePansmith it's my opinion that this is a fairly important thing to get merged and released.
It would be very disheartening for all the time and resources put into building a rocket to be wasted with the player being killed before they can even land on the moon.

@edwar4rd

Copy link
Copy Markdown
Contributor

The same fix should apply to neptunim fillet knife from Aquaculture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Spacesuit Does not Protect from Suffocation/Freezing

3 participants