Fix to Ad-astra Space suit - #453
Open
AnonNautilus wants to merge 2 commits into
Open
AnonNautilus wants to merge 2 commits into
AnonNautilus wants to merge 2 commits into
Conversation
Author
|
Oh also closes #437 |
ChrisLane
approved these changes
Aug 26, 2026
|
@ThePansmith it's my opinion that this is a fairly important thing to get merged and released. |
Contributor
|
The same fix should apply to neptunim fillet knife from Aquaculture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Closes #444
The space suit functions as expected on the moon
Screenshots

Additional context
The
nukelist.jsscript inside the ofkube_js/server_scriptscalls forkubejs/startup_scripts\item.jsand seems to to nuke the nbt data of the ad astra space suits items (Listed as "ad_astra:space_helmet", "ad_astra:space_suit" "ad_astra:space_pants", and "ad_astra:space_boots", are hit by the expression/^ad_astra:(space|netherite_space|jet_suit)_(helmet|suit|pants|boots)$/,).I altered this line to say:
/^ad_astra:(netherite_space|jet_suit)_(helmet|suit|pants|boots)$/,Side note: This has the funny side effect of fixing the rendering of the suit on the player character per issue #437, who also directly saw the fix themself, so kudos to them.
This change actually causes a runoff problem, it brings back the original ad-astra recipe for the space helmet, space boots, and space leggings without using the mechanical crafter. This was fixed with a removal of all "minecraft:crafting_shaped" recipes inside of
kubejs/server_scripts/key_mods/ad_astra.jsfor the items in question (also included in this pull request).