docs: correct the 8.0.0 changelog purchases example - #40
Merged
Merged
Conversation
Two errors in the example shipped with 8.0.0, both mine. `entity(id).schedule` is a property holding a ScheduleApi, not a method, so the snippet as written threw 'schedule is not a function'. The call is `.schedule.upcoming()`. The snippet also filtered on `day.type === 'TICKETED_EVENT'`, which matches nothing useful: purchases are Lightning Lane entries attached to ordinary OPERATING days. Measured against Magic Kingdom today — 48 TICKETED_EVENT entries with no purchases, 26 OPERATING entries with them. The filter is removed and the distinction called out, since filtering on type is the obvious wrong guess. The example is now run verbatim against the published 8.0.0 package rather than written from memory of the API. The entry count is stated as a dated snapshot because the schedule window rolls. No code change; the package is unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only; the published packages are unaffected.
Two errors in the
purchasesexample shipped with the release, both introduced when I wrote the changelog from memory of the API instead of running it.entity(id).scheduleis a property, not a method. The snippet as written fails outright. The call is.schedule.upcoming().TICKETED_EVENT, which matches nothing useful. Purchases are Lightning Lane entries on ordinaryOPERATINGdays. Measured against Magic Kingdom today: 48TICKETED_EVENTentries with no purchases, 26OPERATINGentries with them. The filter is removed and the distinction called out, since filtering ontypeis the obvious wrong guess.Both snippets are now executed verbatim against the published package, with real output pasted as a comment. Entry counts are stated as a dated snapshot rather than a bare number, because the schedule window rolls daily.
🤖 Generated with Claude Code