Skip to content

fix(backfill): an anonymous run says so at the END, where it is read - #31

Merged
cubehouse merged 1 commit into
mainfrom
fix/anonymous-run-says-so
Sep 28, 2026
Merged

cubehouse merged 1 commit into
mainfrom
fix/anonymous-run-says-so

Conversation

@cubehouse

Copy link
Copy Markdown
Member

Every documented example omitted the API key. The docs are the smaller half of the problem.

Without a key the command succeeds. It reads the 7 days anonymous access allows, writes 433 rows of Magic Kingdom instead of ~94,000, and exits 0:

$ themeparks-backfill "magic kingdom" --out .
no API key: reading the 7 days anonymous access allows.
...
  done: 433 rows -> 75ea578a-….ndjson
$ echo $?
0

The notice is printed before a run that takes minutes, so it scrolls away, and the last thing on screen is done: 433 rows. For a customer who has just paid for 400 days that is indistinguishable from success — there is a file, there is no error, and the number means nothing unless you already know what it should have been.

A keyless example is worse than a broken one, because a broken one gets reported.

Changed

  • The notice is repeated at the end of the run, naming what a key would have bought. Now the last four lines read that was ANONYMOUS ACCESS: the last 7 days only.
  • The README and the command's own --help epilog export THEMEPARKS_API_KEY before the example that needs it, and keep saying --list does not — finding a park before you have paid is the point of that flag.

Two mutations pinned: dropping the closing notice, and firing it when a key was given. Both killed. 334 tests.

Companion: ThemeParks_JavaScript for the same change, and web for the two docs pages.

🤖 Generated with Claude Code

@cubehouse
cubehouse force-pushed the fix/anonymous-run-says-so branch from cb5dd97 to 2e37e5e Compare September 28, 2026 18:21
Cube spotted that every documented example omits the API key. The docs are the
smaller half of the problem: without a key the command SUCCEEDS. It reads the 7
days anonymous access allows, writes 433 rows of Magic Kingdom instead of about
94,000, and exits 0.

The existing notice is printed before a run that takes minutes, so it scrolls
away, and the last thing on screen is "done: 433 rows". For a customer who has
just paid for 400 days that is indistinguishable from success -- there is a file,
there is no error, and the number means nothing unless you already know what it
should have been. A keyless example is worse than a broken one, because a broken
one gets reported.

So the notice is repeated at the end of the run, naming what the key would have
bought. Both READMEs and the command's own epilog now export THEMEPARKS_API_KEY
before the example that needs it, and keep saying that --list does not.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@cubehouse
cubehouse force-pushed the fix/anonymous-run-says-so branch from 2e37e5e to b9f8362 Compare September 28, 2026 18:22
@cubehouse
cubehouse merged commit 5d316af into main Sep 28, 2026
6 checks passed
@cubehouse
cubehouse deleted the fix/anonymous-run-says-so branch September 28, 2026 18:24
@cubehouse cubehouse mentioned this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant