-
Notifications
You must be signed in to change notification settings - Fork 724
feat(settings): redesign provider sidebar and configured-provider page (#2155) #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f2bc413
feat(settings): redesign provider sidebar and detail page (#2155)
zhangmo8 0bbaac7
feat(settings): unified add-provider connect-and-load flow (#2155)
zhangmo8 1583bb2
fix(settings): draft validation and deep-link review fixes (#2155)
zhangmo8 9e7e73b
fix(settings): address CI and review feedback (#2155)
zerob13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Do not clear persisted models after draft loading fails.
Line 958 deletes the current catalog for
draft.id.BaseLLMProvider.fetchModelswrites models only afterfetchProviderModels()succeeds. This failure path therefore has no partial write fromfetchModelsto remove.A failed credential update for an existing provider can erase its saved models and model selections. Remove this clear operation. If another draft path can persist models, snapshot and restore the previous catalog instead.
Proposed fix
} catch (error) { - // A failed attempt must not leave a partially seeded model catalog behind. - this.providerSettings.setProviderModels(draft.id, []) const errorMessage = error instanceof Error ? error.message : String(error) return { isOk: false, errorMsg: errorMessage, models: [] }📝 Committable suggestion
🤖 Prompt for AI Agents