Skip to content

refactor(data-mode): drop redundant statusLabel and dead workbenchDataModeLabel helper - #2322

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/data-mode-contract-abl
Sep 5, 2026
Merged

refactor(data-mode): drop redundant statusLabel and dead workbenchDataModeLabel helper#2322
DeliciousBuding merged 1 commit into
masterfrom
fix/data-mode-contract-abl

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

Hard-evidence subtraction on the WorkbenchDataModeContract policy table, per the read-only audit. Full-table ablation is a NEGATIVE experiment — the centralized policy SSOT is KEPT (all boolean fields are derivable from mode but are a real multi-consumer single policy source; abating would fragment policy across desktop/web/gate call sites). allowsMockData and allowsFixtureData are also KEPT (live consumers in shared/src/testing/e2eDataModeContract.ts E2E validator).

This PR removes only:

  • redundant WorkbenchDataModeContract.statusLabel (=== mode for all 5 literals): interface field + 5 table entries; Desktop/Web model read .mode instead (value/type identical).
  • dead workbenchDataModeLabel helper: definition, demo/index.ts re-export, test import/assertions. normalize-exact-input coverage preserved as normalizeWorkbenchDataMode("auto"/"demo+edge"/"mock (auto fallback)") === "auto".

Preserved unchanged: mode literal type, all remaining policy booleans, observed/approved-real semantics, normalization aliases, storage/override/env runtime behavior.

Net: 5 files +8/-24.

Verification: shared dataMode 5/5; desktop model 13/13; web model 40/40; shared/desktop/web typecheck PASS; git diff --check PASS; canonical coverage baseline shared (lines 90.26, uncovered 1) PASS, web (lines 70.13) PASS, desktop (lines 66.32) PASS, all zero-skipped/no-regression.

…aModeLabel helper

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 252f020f-b8c8-4a27-9f4f-fa9833ed41ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit a944fc0 into master Sep 5, 2026
43 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/data-mode-contract-abl branch September 5, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant