macOS signing + notarization - #659
Conversation
|
Apparently this CI build is crashing for others, so I need to test the artifacts? The fully signed thing worked locally but I'll iron out the kinks here. |
|
OK these should run. Tested locally. |
|
Draft until I get time to review this in full. |
891c84d to
aa16d03
Compare
arch1t3cht
left a comment
arch1t3cht
left a comment
There was a problem hiding this comment.
Most of this seems fine to me, given that it's build-system wrangling that mainly has to work on the CI and the release build machine. Just a few notes.
| if: startsWith(matrix.config.os, 'macos-') && matrix.config.buildtype == 'release' | ||
| with: | ||
| name: ${{ matrix.config.name }} - installer | ||
| name: ${{ matrix.config.name }} - ad-hoc installer |
There was a problem hiding this comment.
If the mac debug jobs no longer upload their bundles as artifacts, is there a reason why they're still kept around at all? I guess to make sure that Aegisub still builds with homebrew's libraries and/or do document how to do so?
There was a problem hiding this comment.
Yes, it's to ensure homebrew keeps working. The artifacts were never very useful.
3872062 to
6242e3a
Compare
Keep Developer ID and notarization credentials off CI by uploading an ad-hoc-signed app handoff for tags and manual runs. Add local signing, DMG, and notarization targets and architecture-specific package names.
3390567 to
b7f7056
Compare
2 participants
In preparation for 3.5.0. Seems to work locally at least!