otb: share OO requests across duplicate Polymarket request IDs - #73
Open
chrismaree wants to merge 4 commits into
Open
otb: share OO requests across duplicate Polymarket request IDs#73chrismaree wants to merge 4 commits into
chrismaree wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 851960f159
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
md0x
reviewed
Aug 26, 2026
md0x
reviewed
Aug 26, 2026
md0x
approved these changes
Aug 26, 2026
md0x
left a comment
Collaborator
There was a problem hiding this comment.
Overall, the shared-request approach looks good. I only left two non-blocking comments: remove the unnecessary legacy seeding since OOReporter has not been deployed, and reconsider or justify the hard-coded limit of ten linked request IDs. Approving the overall implementation.
md0x
reviewed
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
report(requestId)once for each ID at settlement.try/catch, so a revert or out-of-gas failure cannot undo the stored resolution or Managed OO settlement.report(requestId); later initialization calls are no-ops.Why
Polymarket can need to initialize replacement token sets with new request IDs while keeping identical resolution rules. The reporter should reuse the existing oracle result instead of rejecting the registration or creating duplicate oracle work.
Impact
report(requestId)off-chain.High risk Sections to review with detail
Validation
cd pm-v2-oo-reporter && forge test— 64 passed, 0 failed.forge fmt --check— passed.