Skip to content

fix(firered): match naming screen and rival intro visuals - #68

Open
Lokesh-shiva wants to merge 1 commit into
UNDERdecoded:mainfrom
Lokesh-shiva:firered-name-entry-fidelity
Open

Lokesh-shiva wants to merge 1 commit into
UNDERdecoded:mainfrom
Lokesh-shiva:firered-name-entry-fidelity

Conversation

@Lokesh-shiva

Copy link
Copy Markdown
Contributor

Summary

  • replace the handmade FireRed naming help controls with the retail DPAD/A/B keypad art and right-aligned help-bar composition
  • restore the fixed name-entry arrow placement/wobble and cartridge cursor palette pulse
  • correct Oak's rival/platform name-menu shift and Gen 3 WindowTemplate frame geometry
  • force the fresh-new-game Type 1 frame for Oak intro menus without changing default Menu/Font callers
  • bump the ROM cache format to v361 so existing FireRed caches regenerate the new naming assets

Validation

  • cross-checked against pokefirered naming/Oak source and FireRed USA BPRE ROM data
  • verified the keypad sheet at ROM offset 0x1EA700 / GBA 0x081EA700, including the text-window palette used by the banner
  • git diff --check passes
  • captured player naming, rival naming, cursor motion, and the rival preset scene; visual result approved

Scope

FireRed naming/Oak visual fidelity only. Review screenshots in ngshots/ were intentionally not committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant