Refresh connection health after OAuth reconnect - #1545
Draft
RhysSullivan wants to merge 6 commits into
Draft
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | e7a3597 | Commit Preview URL Branch Preview URL |
Aug 06 2026, 07:14 PM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | e7a3597 | Aug 06 2026, 07:15 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconnecting an OAuth connection left the stale health verdict (red dot + Expired badge) on screen until a hard page refresh, even though the backend already classified the re-minted grant as healthy.
Two structural causes, both fixed:
last_healthwhen re-minting an OAuth connection.mintOAuthConnectionnow clears it: a re-mint replaces the grant, so any persisted verdict describes a credential that no longer exists.lastHealth.checkedAt), so the refetch after a reconnect (which now carries a cleared verdict) re-triggers the background probe and the dot recovers in place. Applies to both the detail-page row and the integrations-list summary.New e2e scenario (was red before the fix, green after): seeds a DCR MCP OAuth connection against a provider whose grants are dead (expired tokens, refresh rejected as
invalid_grant), restores the provider, completes Reconnect through the real popup, and asserts the row flips to Healthy with no reload. A token-endpoint gate in front of the OAuth test server provides the dead-then-alive provider, mirroring the revoke/restore pattern inhealth-checks-ui.test.ts.Verified: new scenario + the other two in the file,
health-checks-ui(10 scenarios), OAuth-adjacent selfhost scenarios,oauth-flow/connectionsunit tests, format, lint, typecheck.