Fix invisible GitHub logo in the integrations list - #1547
Open
midego1 wants to merge 1 commit into
Open
Conversation
The GitHub presets pointed at svgl's `github_dark.svg`, which is the dark-BACKGROUND variant: its paths are filled `#ffff`. Rendered on the light UI that is a white mark on a white surface, so the GitHub entry in the integrations list and in the connect dialog looked blank. `openai_dark.svg` has the same problem. Point both at integrations.sh instead, which `integration-favicon.tsx` calls executor's single logo source and which the neighbouring Figma, Stripe and Vercel presets already use. Those logos carry their own background, so they stay legible on either theme -- preset icons render as a plain `<img>` with no theme-aware variant selection, so one URL has to work on both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub logo is invisible in the integrations list and in the connect dialog on the light theme.
Both GitHub presets (
openapi"GitHub REST" andgraphql"GitHub GraphQL") point at svgl'sgithub_dark.svg. That is the dark-background variant — its paths are filled#ffff, i.e. white. On the light UI that renders a white mark on a white surface, so the row just looks blank.openai_dark.svghas the identical problem, so it is fixed in the same commit.Swapping to
github_light.svgwould only move the bug to the dark theme: preset icons render as a plain<img src={preset.icon}>with no theme-aware variant selection, so a single URL has to be legible on both.Instead this points both at
https://integrations.sh/logo/<domain>— whichintegration-favicon.tsxdescribes as "executor's single logo source", and which the neighbouring Figma, Stripe and Vercel presets already use. Those assets carry their own background, so they stay readable on either theme.Verified the replacements resolve:
integrations.sh/logo/github.com→ 200image/png(the standard dark-chip Octocat mark),integrations.sh/logo/openai.com→ 200image/svg+xml.