Conversation
91802f5 to
581f946
Compare
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
b16807e to
0245dfc
Compare
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
0d33c96 to
52ed655
Compare
leonardocarreras
left a comment
There was a problem hiding this comment.
Hi @stv0g! Looks nice, I think there are just few comments that you might want to think about.
| --workdir /documentation \ | ||
| $(DOCKER_IMAGE):$(DOCKER_TAG)-dev | ||
|
|
||
| deploy: |
There was a problem hiding this comment.
how are we going to deploy it now to fein?
There was a problem hiding this comment.
Its only going to be deployed to GitHub pages. We then update the DNS-CNAME record of villas.fein-aachen.org to point to the GitHub servers.
@leonardocarreras @al3xa23 Could you take care of this? I believe Stefan Lankes has the credentials to the Hosteurope customer interface where those settings can be changed.
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
al3xa23
left a comment
There was a problem hiding this comment.
Nice work, thanks :)
What do we do about the devcontainer when the Dockerfile is not longer available? Just asking because I use the devcontainer for local testing.
I understand that it still should work from the file devcontainer.json Optional would be to decide how/if the help keeps info about how to use it |
|
I think we need something like this for devcontainer. We would use the node-js as image where all yarn commands can be run: Let me know what you think. If it is okay, I can commit here or make a new PR. |
|
Hi @al3xa23 @leonardocarreras, I think having a separate Dockerfile is a bit overkill. It was mostly used to build an image which we can deploy in the EONERC Kubernetes for hosting the webpage. The approach proposed by Alexandra should work too. |
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Changes
apinode type documentation #139)