Skip to content

Migrate CI to GitHub Actions - #140

Open
stv0g wants to merge 6 commits into
masterfrom
github-ci
Open

Migrate CI to GitHub Actions#140
stv0g wants to merge 6 commits into
masterfrom
github-ci

Conversation

@stv0g

@stv0g stv0g commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Replaces deployment to EONERC Kubernetes with deployment to GitHub pages
  • Removes building of container images
  • Updates references to git.rwth-aachen.de to GitHub
  • Updates VILLASnode submodule
  • Removes documentation for old api node-type (Remove api node type documentation #139)

@stv0g stv0g self-assigned this Jul 30, 2026
@stv0g stv0g added the ci label Jul 30, 2026
@stv0g
stv0g force-pushed the github-ci branch 4 times, most recently from 91802f5 to 581f946 Compare July 30, 2026 21:15
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g
stv0g force-pushed the github-ci branch 5 times, most recently from b16807e to 0245dfc Compare July 30, 2026 21:39
pjungkamp and others added 3 commits July 31, 2026 07:29
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g
stv0g force-pushed the github-ci branch 2 times, most recently from 0d33c96 to 52ed655 Compare July 31, 2026 05:45
@stv0g stv0g mentioned this pull request Jul 31, 2026
@stv0g stv0g linked an issue Jul 31, 2026 that may be closed by this pull request

@leonardocarreras leonardocarreras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stv0g! Looks nice, I think there are just few comments that you might want to think about.

Comment thread docs/node/installation.md Outdated
Comment thread docs/node/installation.md Outdated
Comment thread docs/node/installation.md Outdated
Comment thread Makefile
--workdir /documentation \
$(DOCKER_IMAGE):$(DOCKER_TAG)-dev

deploy:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are we going to deploy it now to fein?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its only going to be deployed to GitHub pages. We then update the DNS-CNAME record of villas.fein-aachen.org to point to the GitHub servers.

@leonardocarreras @al3xa23 Could you take care of this? I believe Stefan Lankes has the credentials to the Hosteurope customer interface where those settings can be changed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stlankes should we talk to you separately?

Comment thread .github/workflows/build.yaml
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>

@al3xa23 al3xa23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks :)

What do we do about the devcontainer when the Dockerfile is not longer available? Just asking because I use the devcontainer for local testing.

@leonardocarreras

Copy link
Copy Markdown
Contributor

Nice work, thanks :)

What do we do about the devcontainer when the Dockerfile is not longer available? Just asking because I use the devcontainer for local testing.

I understand that it still should work from the file devcontainer.json

Optional would be to decide how/if the help keeps info about how to use it

@al3xa23

al3xa23 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

I think we need something like this for devcontainer. We would use the node-js as image where all yarn commands can be run:
{ "name": "VILLASdocumentation", "image": "node:23.11-bookworm", "forwardPorts": [ 3000 ], "portsAttributes": { "3000": { "label": "Development Server", "onAutoForward": "openBrowserOnce" } }, "remoteUser": "node" }

Let me know what you think. If it is okay, I can commit here or make a new PR.

@stv0g

stv0g commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Hi @al3xa23 @leonardocarreras,

I think having a separate Dockerfile is a bit overkill. It was mostly used to build an image which we can deploy in the EONERC Kubernetes for hosting the webpage.

The approach proposed by Alexandra should work too.

Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old docs

5 participants