Skip to content

Prevent updater downloads from hanging indefinitely - #1477

Draft
Valkirie with Copilot wants to merge 2 commits into
mainfrom
copilot/update-to-1211-fix-download-stall
Draft

Valkirie with Copilot wants to merge 2 commits into
mainfrom
copilot/update-to-1211-fix-download-stall

Conversation

Copilot AI commented Sep 12, 2026

Copy link
Copy Markdown

GitHub release downloads could stall indefinitely while fetching the USBip asset, leaving the updater stuck without feedback.

  • Bounded streaming: Apply a 30-second timeout to each response-body read.
  • Failure handling: Timed-out transfers flow through the existing failed-download state.
while ((read = await sourceStream
    .ReadAsync(buffer, 0, buffer.Length)
    .WaitAsync(DownloadReadTimeout)) > 0)
{
    // write and report progress
}

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5b7d5f8e-4438-4ca3-b6fc-06660a0e75be

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI linked an issue Sep 12, 2026 that may be closed by this pull request
9 tasks
Co-authored-by: Valkirie <934757+Valkirie@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix download stall issue when updating to version 1.2.1.1 Prevent updater downloads from hanging indefinitely Sep 12, 2026
Copilot AI requested a review from Valkirie September 12, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update to 1.2.1.1: download stalled?

2 participants