feat: add hub funded spoke pool testnet VIP - #762
Draft
Debugger022 wants to merge 1 commit into
Draft
Conversation
Debugger022
commented
Sep 1, 2026
Debugger022
commented
Contributor
- Foundation draft only. The spoke comptroller, markets, adapter and yield source are unbuilt, so their addresses are zero placeholders and the proposal cannot be simulated until they land.
- Command order is load-bearing in four places: acceptOwnership before any owner-gated setter, setPriceOracle before addPool, the bounded oracle before the pool serves a borrow or redeem, and addMarket before the supply allowlist is armed.
- Grants only the six ACM roles this chain does not already cover. The rest are held by the timelock or the registry as wildcards, checked on chain
- Risk parameters the PRD does not specify are left as TODO, as are the bStock liquidation calls, which have no testnet target yet.
- Foundation draft only. The spoke comptroller, markets, adapter and yield source are unbuilt, so their addresses are zero placeholders and the proposal cannot be simulated until they land. - Command order is load-bearing in four places: acceptOwnership before any owner-gated setter, setPriceOracle before addPool, the bounded oracle before the pool serves a borrow or redeem, and addMarket before the supply allowlist is armed. - Grants only the six ACM roles this chain does not already cover. The rest are held by the timelock or the registry as wildcards, checked on chain - Risk parameters the PRD does not specify are left as TODO, as are the bStock liquidation calls, which have no testnet target yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.