Conversation
🤖 PR SummaryThe overview should be standalone, with per-file specifics included, no critique, and organized under relevant headers. Since the PR is a Statistics
Lean Declarations
📋 **Additional Analysis**The diff has several violations of the style guide and contains syntax errors that prevent compilation. 📄 **Per-File Summaries**
Last updated: 2026-09-08 03:09 UTC. |
|
Continuing this compatibility work in zksecurity#1, targeting the zkSecurity fork for the Better Codes dependency. That PR includes Lean/Mathlib 4.33.1, the existing Rabin wrappers, this additional explicit-instance fix, and the fresh-kernel replay regression; its local build and test suite pass. Closing this proposal in favor of that review target. The existing fork branch and original pinned commit remain available for downstream users. |
Fresh kernel replay of the imported
KoalaBear.sexticPoly_irreducibleproof can fail with a deep-recursion error on Lean 4.33.1, even though the original module builds. Pass the KoalaBearZModfield and finite-type instances explicitly to the degree-six Rabin theorem so the certificate and theorem use the same instance path.The polynomial, theorem statement, certificates, and trust assumptions are unchanged. The existing regression test imports the proof and checks its original body against its original type in a fresh kernel environment.
Validation:
mainat3468b38c8fd270f93f55a259220a8abc544e7437. All checks below pass on branch commit9a0130b2de4909efd71760948cec9c50edb3031dwith Lean 4.33.1:lake build(169 seconds) andlake test(75 seconds).lake exe axiomsweep --check: 9,870 declarations across 346 modules; nosorryor non-standard-axiom taint.lake env lean tests/CompPolyTests/Fields/KoalaBear/SexticReplay.lean(77 seconds), directly executing the existing regression rather than relying only on its cached build.GitHub CI still requires maintainer approval to run this fork's workflows; those runs are not being reported as passed. Please approve the pending CI runs when reviewing this draft.
The competition integration temporarily pins the original fix commit
9d36af56cd57a468ade1cbbc8fae324983d79708from this fork. That commit remains in this branch's history, so downstream users can continue with their tested dependency while this PR is reviewed.